Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Changing Perspective Character to Minor Character Creates Error #87

Closed
ryanreso1993 opened this issue May 22, 2021 · 6 comments · Fixed by #99
Closed

Changing Perspective Character to Minor Character Creates Error #87

ryanreso1993 opened this issue May 22, 2021 · 6 comments · Fixed by #99
Labels
bug Something isn't working

Comments

@ryanreso1993
Copy link
Contributor

ryanreso1993 commented May 22, 2021

Create two characters: Bob and Alice
Create a character arc for Bob
Open the Character Conflict tool for Bob's arc
Add Alice as an opponent to Bob
Change the perspective to Bob

What I expect to happen:
Then the other character becomes a Major Character

What actually happens:
Then the other character becomes a Major Character, but the program displays this error:

Error message:

com.soyle.stories.domain.theme.CharacterIsNotMajorCharacterInTheme
at com.soyle.stories.usecase.theme.examineCentralConflictOfTheme.ExamineCentralConflictOfThemeUseCase.getMajorCharacter(ExamineCentralConflictOfThemeUseCase.kt:91)
at com.soyle.stories.usecase.theme.examineCentralConflictOfTheme.ExamineCentralConflictOfThemeUseCase.getExaminedCharacterChange(ExamineCentralConflictOfThemeUseCase.kt:38)
at com.soyle.stories.usecase.theme.examineCentralConflictOfTheme.ExamineCentralConflictOfThemeUseCase.invoke(ExamineCentralConflictOfThemeUseCase.kt:27)
at com.soyle.stories.theme.characterConflict.CharacterConflictController$getValidState$1.invokeSuspend(CharacterConflictController.kt:51)
at com.soyle.stories.theme.characterConflict.CharacterConflictController$getValidState$1.invoke(CharacterConflictController.kt)
at com.soyle.stories.theme.characterConflict.CharacterConflictController$getValidState$1.invoke(CharacterConflictController.kt)
at com.soyle.stories.common.AsyncThreadTransformer$async$1$1.invokeSuspend(ThreadTransformerImpl.kt:12)
at com.soyle.stories.common.AsyncThreadTransformer$async$1$1.invoke(ThreadTransformerImpl.kt)
at com.soyle.stories.common.AsyncThreadTransformer$async$1$1.invoke(ThreadTransformerImpl.kt)
at kotlinx.coroutines.intrinsics.UndispatchedKt.startUndispatchedOrReturnIgnoreTimeout(Undispatched.kt:102)
at kotlinx.coroutines.TimeoutKt.setupTimeout(Timeout.kt:148)
at kotlinx.coroutines.TimeoutKt.withTimeout(Timeout.kt:44)
at com.soyle.stories.common.AsyncThreadTransformer$async$1.invokeSuspend(ThreadTransformerImpl.kt:11)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665)

@ryanreso1993 ryanreso1993 added the bug Something isn't working label May 22, 2021
@b-camphart b-camphart linked a pull request Jun 28, 2021 that will close this issue
@b-camphart b-camphart assigned ryanreso1993 and unassigned b-camphart Jul 1, 2021
@b-camphart
Copy link
Collaborator

@ryanreso1993 please verify with new release

@ryanreso1993
Copy link
Contributor Author

@ryanreso1993 please verify with new release

Cannot reproduce, unable to locate Character Conflict Tool from Character Arc

@b-camphart
Copy link
Collaborator

Take a look in the theme list tool

@ryanreso1993
Copy link
Contributor Author

ryanreso1993 commented Aug 1, 2021

Still running into error. Kindly advise.

Can:
Create two characters Bob and Alice
Create a theme
Right click the theme and open Examine Central Conflict

Cannot:
Add Alice as an opponent to Bob
Change the perspective to Bob

@b-camphart b-camphart assigned b-camphart and unassigned ryanreso1993 Aug 3, 2021
@b-camphart
Copy link
Collaborator

Right now, the only perspective characters you can select are characters in the theme. Should the menu look like this instead:

Major Characters
Minor Characters
Other Characters in Project
Create New Character

Would that make sense?

@b-camphart b-camphart assigned ryanreso1993 and unassigned b-camphart Aug 3, 2021
@ryanreso1993
Copy link
Contributor Author

ryanreso1993 commented Aug 3, 2021 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants