Use a pinned devcontainer base image version #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnboyes
force-pushed
the
docker-image-dependency
branch
from
da51b50 to
e667b27
Compare
We want to pin to the most specific version we can, to ensure that the devcontainer builds are always reproducible. This is despite the general guidance from Microsoft for these images being to use ["the major release version of this tag to avoid breaking changes while still taking fixes and content additions as they land. e.g. `0-buster`"][1] We will still take fixes and content additions as they land, as we use Dependabot to keep us up to date. Dependabot will create a PR whenever there is a new version of the base image, and we then manually apply that new version to the `devcontainer.json` (full details on how to do this are in the `DEPENDENCIES.md`). See also [this documentation on the base image versions][2] [1]: https://hub.docker.com/_/microsoft-vscode-devcontainers?tab=description [2]: https://github.com/microsoft/vscode-dev-containers/tree/master/containers/debian#using-this-definition-with-an-existing-folder
johnboyes
force-pushed
the
docker-image-dependency
branch
from
e667b27 to
fa202c1
Compare
13 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to pin to the most specific version we can, to ensure that the
devcontainer builds are always reproducible.
This is despite the general guidance from Microsoft for these images
being to use "the major release version of this tag to avoid breaking
changes while still taking fixes and content additions as they land.
e.g.
0-buster"We will still take fixes and content additions as they land, as we use
Dependabot to keep us up to date. Dependabot will create a PR whenever
there is a new version of the base image, and we then manually apply and
test it (details on how to do this are in the
DEPENDENCIES.md).See also this documentation on the base image versions