-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Reliable test job #685
Merged
Merged
Reliable test job #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reliability increased by:
|
/*
* TODO test need fixing as calls to client are time dependent so this test
* sometimes fails. For example j.getState() may or may not call the client
* depending on when the previous state was requested.
*/
The sensitivity was due to things like the caching period being unconfigurable. Fixed that (just for testing). |
That failure up above was a transient in networking unrelated to our tests. |
If this causes failures, I'll be very sorry and fix it then. |
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our tests was disabled because it was not generating reliable results (and had become steadily more broken over time; code that isn't tested at all is code that can be going horribly wrong). This is about trying to make it run and be more reliable.