Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reliable test job #685

Merged
merged 11 commits into from
Feb 1, 2023
Merged

Reliable test job #685

merged 11 commits into from
Feb 1, 2023

Conversation

dkfellows
Copy link
Member

One of our tests was disabled because it was not generating reliable results (and had become steadily more broken over time; code that isn't tested at all is code that can be going horribly wrong). This is about trying to make it run and be more reliable.

@dkfellows dkfellows added the bug Something isn't working label Jan 12, 2023
@dkfellows dkfellows added this to the 7.0.0 milestone Jan 12, 2023
@dkfellows dkfellows self-assigned this Jan 12, 2023
@dkfellows
Copy link
Member Author

Reliability increased by:

  1. ensuring that worker threads in the mock server have actually started
  2. defining and using a connection object (wrapping the connected socket) so that a server can have multiple connections open at once
  3. making the match for the number of keepalives less precise; the exact number is not important, so long as they're sent.

@dkfellows dkfellows marked this pull request as ready for review January 12, 2023 16:09
@dkfellows dkfellows requested a review from Christian-B January 12, 2023 16:09
@dkfellows
Copy link
Member Author

dkfellows commented Jan 12, 2023

I've not yet removed this comment:

	/*
	 * TODO test need fixing as calls to client are time dependent so this test
	 * sometimes fails. For example j.getState() may or may not call the client
	 * depending on when the previous state was requested.
	 */

I'm not sure if it applies or not.

The sensitivity was due to things like the caching period being unconfigurable. Fixed that (just for testing).

@dkfellows
Copy link
Member Author

That failure up above was a transient in networking unrelated to our tests.

@dkfellows dkfellows merged commit e036bea into master Feb 1, 2023
@dkfellows dkfellows deleted the reliable-test-job branch February 1, 2023 14:55
@dkfellows
Copy link
Member Author

If this causes failures, I'll be very sorry and fix it then.

@dkfellows dkfellows linked an issue Feb 17, 2023 that may be closed by this pull request
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestJob timing issue.
1 participant