Makes Sphinx more like other repo #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge done but Branch left for @dkfellows to review that nothing was lost. if nothing was lost please delete branch |
|
That looks fine at first glance. I think the code that got replaced was the remnants of stuff that was there for debugging what's going on inside Sphinx… The proof of the pudding is in the eating. Do the docs look right? If so, we're fine! 😆 |
|
And it doesn't work on RTD. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inlcudes fixes from SpiNNakerManchester/SpiNNFrontEndCommon#806