-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fixed location #464
Merged
Merged
Fixed location #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 14, 2022
rowleya
approved these changes
Sep 27, 2022
This was referenced Sep 28, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ChipAndCoreConstraint was the only constraint left
Yet there was a lot of overhead for a something rarely used.
These Prs remove all the constraint stuff and replace it with a fixed_location
The biggest change is that a vertex is no longer a ConstrainedObject so does have have a constraints param in its init.
Instead AbstractVertex (and therefor all vertex classes) have the methods
set_fixed_location(x,y,p=None)
and the
get_fixed_location which returns a ChipAndCore class IF and only if there is a fixed location BEFORE doing placements.
To avoid having to pass the fixed_location from ApplicationVertex to MachineVertex the get in the MachineVertex will fall back to the App if needed and possible.
The number of files changed show how much work was done for something used so little.
Must be done at the same time as:
SpiNNakerManchester/SpiNNFrontEndCommon#976
SpiNNakerManchester/sPyNNaker#1219
SpiNNakerManchester/MarkovChainMonteCarlo#34
SpiNNakerManchester/SpiNNGym#50
SpiNNakerManchester/SpiNNakerGraphFrontEnd#224
SpiNNakerManchester/SpiNNaker_PDP2#63
tested by:
SpiNNakerManchester/IntegrationTests#139
...