Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixed location #464

Merged
merged 12 commits into from
Sep 27, 2022
Merged

Fixed location #464

merged 12 commits into from
Sep 27, 2022

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Sep 14, 2022

The ChipAndCoreConstraint was the only constraint left

Yet there was a lot of overhead for a something rarely used.

These Prs remove all the constraint stuff and replace it with a fixed_location

The biggest change is that a vertex is no longer a ConstrainedObject so does have have a constraints param in its init.

Instead AbstractVertex (and therefor all vertex classes) have the methods
set_fixed_location(x,y,p=None)
and the
get_fixed_location which returns a ChipAndCore class IF and only if there is a fixed location BEFORE doing placements.

To avoid having to pass the fixed_location from ApplicationVertex to MachineVertex the get in the MachineVertex will fall back to the App if needed and possible.

The number of files changed show how much work was done for something used so little.

Must be done at the same time as:
SpiNNakerManchester/SpiNNFrontEndCommon#976
SpiNNakerManchester/sPyNNaker#1219
SpiNNakerManchester/MarkovChainMonteCarlo#34
SpiNNakerManchester/SpiNNGym#50
SpiNNakerManchester/SpiNNakerGraphFrontEnd#224
SpiNNakerManchester/SpiNNaker_PDP2#63

tested by:
SpiNNakerManchester/IntegrationTests#139

...

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants