Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Mvertex label #476

Merged
merged 4 commits into from
Oct 17, 2022
Merged

Mvertex label #476

merged 4 commits into from
Oct 17, 2022

Conversation

Christian-B
Copy link
Member

The default label of a Machine vertex is the Application vertex label and the slice.

However the slice str has gotten more complex so the labels looks silly.

This pr.

  1. simplifies the str of the slice
  2. removes the extra test like "MachineVertex for" from the labels.

@Christian-B Christian-B requested a review from rowleya October 17, 2022 14:27
@Christian-B Christian-B mentioned this pull request Oct 17, 2022
Merged
andrewgait
andrewgait approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@andrewgait andrewgait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good idea to me.

@Christian-B Christian-B merged commit d46d6db into master Oct 17, 2022
@Christian-B Christian-B deleted the mvertex_label branch October 17, 2022 16:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@andrewgait andrewgait andrewgait approved these changes

@rowleya rowleya Awaiting requested review from rowleya

Assignees

@rowleya rowleya

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Christian-B @andrewgait @rowleya