Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix pool dense #491

Merged
merged 15 commits into from
Feb 28, 2023
Merged

Fix pool dense #491

merged 15 commits into from
Feb 28, 2023

Conversation

rowleya
Copy link
Member

@rowleya rowleya commented Feb 21, 2023

Fixes issue with "overlap" routing where input from a device arrives from multiple chips (i.e. an FPGA) and one of those chips is connected to one subset of machine vertices from an application vertex and a different chip is connected to a different subset of machine vertices! This can occur if the application vertex has so many machine vertices as to be bisected by the device interface points.

Copy link
Contributor

@andrewgait andrewgait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@andrewgait andrewgait merged commit c024231 into master Feb 28, 2023
@andrewgait andrewgait deleted the fix_pool_dense branch February 28, 2023 16:48
@andrewgait andrewgait restored the fix_pool_dense branch February 28, 2023 16:49
@andrewgait andrewgait deleted the fix_pool_dense branch February 28, 2023 16:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants