Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

implementing bio-metric pull #59

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

maifeeulasad
Copy link

Issue : #52
Discussion : #58

@maifeeulasad maifeeulasad changed the title implementing bio-metric implementing bio-metric pull Mar 19, 2021
@Spikeysanju
Copy link
Owner

Screenshot_2021-03-27-14-06-50-113_dev.spikeysanju.expensetracker.jpg

Hey @maifeeulasad I have reviewed your PR it looks good. But the main purpose of this Bio-Metric authentication is to provide privacy.

But in above picture we clearly see able to see the dashboard values.

Also I noticed application crashes whenever I tap apart from the the authenticate area.

Can you please fix above two issues if possible. Once it's done I will be happy to merge your PR.

Thanks for your PR. Have a great day buddy!

…l + refactored PrefsDataStore, as it is being used in multiple class across multiple files

now without proper authentication app can't be used, as well as even the values from different views can't be seen
@maifeeulasad
Copy link
Author

@Spikeysanju can you check out once more, I've update the PR. currently it starts in a different fragment, an authentication fragment. then if it is properly authenticated, it goes to doing whatever it was doing previously. You can check directly here : ca9ad27

And let me know if it needs something more.

@Spikeysanju Spikeysanju reopened this Apr 10, 2021
@Spikeysanju
Copy link
Owner

@maifeeulasad Buddy thanks for the new PR. I will review this PR by EOD. Have a great day 🙌

@maifeeulasad
Copy link
Author

Hello, @Spikeysanju hope you are doing well. Have you checked out this PR. Can I get any update on this? If this PR lacks anything, please let me know.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants