Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

explicitly declare implicit nullable parameter declarations #254

Closed
wants to merge 1 commit into from
Closed

explicitly declare implicit nullable parameter declarations #254

wants to merge 1 commit into from

Conversation

tacman
Copy link
Contributor

@tacman tacman commented Dec 15, 2024

Target branch: 1.3.x

  • [ x] Includes Deprecations

This PR gets rid of the deprecation warnings and makes the bundle one step closer to working in php 8.4

@tacman
Copy link
Contributor Author

tacman commented Dec 15, 2024

Looks like these are incorporated in #255.

@tacman tacman closed this Dec 15, 2024
@tacman tacman mentioned this pull request Dec 15, 2024
Open
@Spomky Spomky mentioned this pull request Dec 16, 2024
Merged
4 tasks
@Spomky
Copy link
Member

Spomky commented Dec 16, 2024

Hello @tacman,

Indeed I saw the same deprecation warnings and fixed them in the dev branch of #255.
But as it may impact applications running on the last minor version 1.2, I decided to create a dedicated PR and consider it as a bug.
Version 1.2.7 should fix these messages.

@tacman tacman deleted the null-deprecations branch December 16, 2024 11:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tacman @Spomky