Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cannot Build with dbus_mpris #1194

Closed
2 of 6 tasks
klay2000 opened this issue Mar 21, 2023 · 1 comment · Fixed by #1145
Closed
2 of 6 tasks

Cannot Build with dbus_mpris #1194

klay2000 opened this issue Mar 21, 2023 · 1 comment · Fixed by #1145
Labels
bug A functionality or parts of a program that do not work as intended
Milestone

Comments

@klay2000
Copy link
Contributor

Description
Compiling with dbus_mpris enabled fails with the following errors:

error[E0404]: expected trait, found enum `PlayContextId`
   --> src/dbus_mpris.rs:352:41
    |
352 |             struct AnyContextId(Box<dyn PlayContextId>);
    |                                         ^^^^^^^^^^^^^ not a trait

error[E0404]: expected trait, found enum `PlayContextId`
   --> src/dbus_mpris.rs:363:18
    |
363 |             impl PlayContextId for AnyContextId {}
    |                  ^^^^^^^^^^^^^ not a trait

error[E0404]: expected trait, found enum `PlayableId`
   --> src/dbus_mpris.rs:366:34
    |
366 |                 Playable(Box<dyn PlayableId>),
    |                                  ^^^^^^^^^^ not a trait

To Reproduce
cargo build --features dbus_mpris

Compilation flags

  • dbus_mpris
  • dbus_keyring
  • alsa_backend
  • portaudio_backend
  • pulseaudio_backend
  • rodio_backend

Versions (please complete the following information):

  • OS: Ubuntu 20.04.5 LTS
  • Spotifyd: commit hash e640aca
  • cargo: cargo 1.63.0 (fd9c4297c 2022-07-01)
@klay2000 klay2000 added the bug A functionality or parts of a program that do not work as intended label Mar 21, 2023
@eladyn
Copy link
Member

eladyn commented Mar 21, 2023

That semver breaking rspotify 0.11.6 release / the temporary workaround is really causing a lot of problems. 😅

This issue has been raised in #1193, #1144 and will be fixed with #1145. The last mentioned PR should be merged within the next few days.

Edit: I'm going to leave this one open so that hopefully people get to see this before opening new duplicate issues.

@eladyn eladyn added this to the v0.3.5 milestone Mar 21, 2023
@eladyn eladyn linked a pull request Mar 21, 2023 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug A functionality or parts of a program that do not work as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants