-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
remove workaround for rspotify id types #1145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool!
I rebased the PR on current master. Maybe we can get this merged soon-ish, such that CI passes again? |
@eladyn maybe we should add --locked in CI? That fixes the CI, since it uses the versions from Cargo.lock |
@Icelk That might indeed be a good idea. Well, the effort of fixing CI failures is – in theory – not that big. It's only becoming a hurdle, when other CI for other PRs are failing due to the fix not yet being merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
69eecea
to
ffa43c2
Compare
@slondr Sorry for dismissing your review once again. GitHub was acting very strangely and somehow told me that there were still conflicts even though I remember resolving them some days ago? I now resolved them manually and hopefully, this time everything should be fine. |
5daffe0
to
c4001da
Compare
Ugh, somehow it now suddenly wants to use |
I'll finish up #1182 today, which includes the MSRV bump. It would block on this, so if we merge the two right after each other, everything should work out. |
ac0ff40
to
d5b3fd0
Compare
Now, we should (finally) be fine! |
aight let's send it yeet |
This upgrades
rspotify
to0.11.6
and removes the workaround that was introduced in #1079, for which there is now much better library support.related: #1144