Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: add changelog #714

Merged
merged 1 commit into from
Nov 13, 2020
Merged

chore: add changelog #714

merged 1 commit into from
Nov 13, 2020

Conversation

robinvd
Copy link
Contributor

@robinvd robinvd commented Nov 11, 2020

as discussed in #702 (comment)

ping @sirwindfield

@robinvd robinvd added the enhancement A new feature that would improve Spotifyd label Nov 11, 2020
@robinvd robinvd mentioned this pull request Nov 11, 2020
@mainrs
Copy link
Member

mainrs commented Nov 12, 2020

Yep, something like this looks good!

@mainrs
Copy link
Member

mainrs commented Nov 12, 2020

Not sure why CI gets triggered though, I set the paths to only account for Rust related files:

on:
pull_request:
paths:
- '**.rs'
- 'Cargo.toml'
- 'Cargo.lock'

@mainrs
Copy link
Member

mainrs commented Nov 12, 2020

Ah, looks like it is a conflict with the protected branch rule and the fact that the filter is applied inside the workflow:
https://github.heygears.community/t/path-filtering-on-required-pull-request-checks/18402/3

Just ping me if you want to get this merged into master, as I can still merge due to admin rights.

Edit: Might be worth looking into the alternative that is linked above, someone wrote an action for this use case if I understood correctly.

@robinvd
Copy link
Contributor Author

robinvd commented Nov 13, 2020

@sirwindfield i think with you two approving, this can be merged.

@mainrs mainrs changed the title add changelog chore: add changelog Nov 13, 2020
@mainrs mainrs merged commit 39106ed into Spotifyd:master Nov 13, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement A new feature that would improve Spotifyd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants