Match inherited tags #1064
Merged
Match inherited tags #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test case verifying matching of inherited tags and modified current test case for smart parsing of tags.
Update the smart parser to match tags against a prefix's inherited tags in addition to the tags added to the prefix specifically.
houndci-bot
reviewed
Sep 28, 2016
| self.assertEqual(expected, result) | ||
|
|
||
| # match two levels of inherited tags | ||
| expected = [ p1.prefix ] + expected |
There was a problem hiding this comment.
whitespace after '['
whitespace before ']'
houndci-bot
reviewed
Sep 28, 2016
| self.assertEqual(expected, result) | ||
|
|
||
| # match an inherited tag | ||
| expected = [ p2.prefix ] + expected |
There was a problem hiding this comment.
whitespace after '['
whitespace before ']'
houndci-bot
reviewed
Sep 28, 2016
|
|
||
| # add a few prefixes | ||
| p1 = th.add_prefix('192.168.0.0/16', 'reservation', 'root', [ 'tag1' ]) | ||
| p2 = th.add_prefix('192.168.0.0/20', 'reservation', 'test', [ 'tag2' ]) |
There was a problem hiding this comment.
whitespace after '['
whitespace before ']'
houndci-bot
reviewed
Sep 28, 2016
| th = TestHelper() | ||
|
|
||
| # add a few prefixes | ||
| p1 = th.add_prefix('192.168.0.0/16', 'reservation', 'root', [ 'tag1' ]) |
There was a problem hiding this comment.
whitespace after '['
whitespace before ']'
houndci-bot
reviewed
Sep 28, 2016
| @@ -1540,6 +1539,46 @@ def testPrefixInclusion(self): | |||
| self.assertEqual(expected, result) | |||
|
|
|||
|
|
|||
| def testTags(self): | |||
Create extension citext as super user in the SQL Makefile.
|
Accidentally I also found that the creation of the citext extension never had worked in the SQL Makefile. Apparently the tests never covered it before 😄 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the smart parser to match tags against a prefix's inherited as well as "own" tags.
Fixes #1055.