Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

SrainBuffer and its derived class #73

Merged
merged 14 commits into from
Dec 21, 2017
Merged

SrainBuffer and its derived class #73

merged 14 commits into from
Dec 21, 2017

Conversation

SilverRainZ
Copy link
Member

  • Refactor SrainChat and rename it to SrainBuffer
  • Implement some derived class:
SrainBuffer
    ├── SrainServerBuffer
    └── SrainChatBuffer
        ├── SrainChannelBuffer
        └── SrainPrivateBuffer

ref: #66

@SilverRainZ SilverRainZ added this to the 0.07 milestone Dec 18, 2017
@SilverRainZ SilverRainZ mentioned this pull request Dec 18, 2017
Closed
22 tasks
@SilverRainZ SilverRainZ merged commit ed0b7f1 into master Dec 21, 2017
@SilverRainZ SilverRainZ deleted the buffer branch December 24, 2017 15:26
SilverRainZ added a commit that referenced this pull request Apr 19, 2018
@SilverRainZ
Sui(refactor): remove the class inherited from SuiBuffer
2fa0505 
The derived class is not good as imaginary. Current every SuiBuffer
should has a context(SrnChat) from Core module, it is tedious to get
context from parent class.

This commit actually revert PR #73
SilverRainZ added a commit that referenced this pull request Jun 3, 2018
@SilverRainZ
Sui(chore): add SuiBuffer subclass again :(
7fdfa8d 
We need SuiBuffer subclass for: holding SuiJoinPanel, forwarding message
and etc.

This commit actually reverts commit 2fa0505, restore PR #73
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cleanup mod-ui
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@SilverRainZ