Add plain option for target coverage #36
Merged
+9
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no visibility is specified for target, adding coverage with any of the two options:
PUBLIC
orINTERFACE
(PRIVATE
is default) results in error:where
I added
PLAIN
option which do not add any visibility, as the default option is alwaysPRIVATE
.Alternatively, one should add
PRIVATE
option and leave no option equivalent toPLAIN
but this will break back-compatibility, which might not be an issue perhaps. Actually this is what I would prefer Makes it more consistent.