Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

R53_ALIAS hasn't been registered as a custom Record Type #310

Closed
masterzen opened this issue Feb 1, 2018 · 1 comment
Closed

R53_ALIAS hasn't been registered as a custom Record Type #310

masterzen opened this issue Feb 1, 2018 · 1 comment

Comments

@masterzen
Copy link
Contributor

Hi,

My Route53 ALIAS patch is not complete, it misses a call to providers.RegisterCustomRecordType and thus the v0.2.5 fails miserably when trying to use R53_ALIAS with the error:

Unsupported record type (R53_ALIAS) domain=... name=...

It's possible I've lost this line during a rebase.

Anyhow, I'll push a PR ASAP.

Sorry for the issue.
masterzen pushed a commit to masterzen/dnscontrol that referenced this issue Feb 1, 2018
Fix R53_ALIAS not being registered as custom type (StackExchange#310)
ab8a6e0 
Apparently I've forgot to register the R53_ALIAS custom record
type, thus preventing to use R53_ALIAS in a js file.
The integration still worked fine because they probably don't run
the validation.
@masterzen
Copy link
Contributor Author

This is fixed by PR #311.

tlimoncelli pushed a commit that referenced this issue Feb 1, 2018
Fix R53_ALIAS not being registered as custom type (#310) (#311)
4c80526 
Apparently I've forgot to register the R53_ALIAS custom record
type, thus preventing to use R53_ALIAS in a js file.
The integration still worked fine because they probably don't run
the validation.
rblenkinsopp pushed a commit to rblenkinsopp/dnscontrol that referenced this issue Aug 21, 2020
Fix R53_ALIAS not being registered as custom type (StackExchange#310) (…
fc7f8b6 
…StackExchange#311)

Apparently I've forgot to register the R53_ALIAS custom record
type, thus preventing to use R53_ALIAS in a js file.
The integration still worked fine because they probably don't run
the validation.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@masterzen @tlimoncelli