MAINT: Linting #1380
MAINT: Linting #1380
Conversation
|
Hi @tlimoncelli , what can I do for you? If you want me to check the changes in the provider I am an maintainer (Transip): You only added a comment and it is perfect. |
Yes, verifying the changes related to TransIP is all I needed. (You had it easy: other people had bigger changes.) Thanks for checking in! (Edit: Clarified which changes) |
|
Easyname looks good, just the one change for |
providers/hexonet/domains.go
Outdated
| @@ -21,6 +21,9 @@ func (n *HXClient) EnsureDomainExists(domain string) error { | |||
| } | |||
| } else if code == 531 { | |||
| return n.GetHXApiError("Not authorized to manage dnszone", domain, r) | |||
| // FIXME(tlim) go-staticcheck reports: | |||
| // identical expressions on the left and right side of the '||' operator (SA4000) | |||
| // Perhaps the right side should be n.IsError() or deleted? | |||
| } else if r.IsError() || r.IsError() { | |||
There was a problem hiding this comment.
Morning @tlimoncelli
I suggest to rewrite
} else if r.IsError() || r.IsError() {to
} else if r.IsError() || r.IsTmpError() {Probably an oversight on my end some time ago.
Find the Reference to IsTmpError function here.
That's it basically :-)
There was a problem hiding this comment.
Changed as suggested. If it passed CI, I'll mark this as done.
|
Sorry to rush folks but I'd like to do a release soon, so I'm going to merge this. The changes are rather low-risk. The new release will go out early next week but first we're going to use it inside Stack Overflow for a bit as we usually do. |
I fixed many, many, lint and staticcheck warnings and errors. Sorry for the mega-PR but its the fastest way to get them all done.
CC @tresni @Papakai @blackshadev @mikenz @philhug @tlimoncelli
Note: I haven't used the checklist feature before. Let's see if this works. I've made a checklist of the files in this PR. We'll check them off as people confirm them. I may check off some myself if they are just comments.)