Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

GCLOUD: Stop using deprecated New() call #1409

Merged
merged 5 commits into from
Feb 11, 2022
Merged

GCLOUD: Stop using deprecated New() call #1409

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c456e2
Make staticcheck more strict and fix new warnings
tlimoncelli Feb 11, 2022
7a8a090
Revert "Make staticcheck more strict and fix new warnings"
tlimoncelli Feb 11, 2022
6999083
GCLOUD: Stop using deprecated .New() call
tlimoncelli Feb 11, 2022
ed7a5ff
Merge branch 'master' into tlim_gcloud
tlimoncelli Feb 11, 2022
04a2348
Merge branch 'master' into tlim_gcloud
tlimoncelli Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion providers/gcloud/gcloudProvider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"time"

"google.golang.org/api/googleapi"
"google.golang.org/api/option"

gauth "golang.org/x/oauth2/google"

Expand Down Expand Up @@ -77,7 +78,9 @@ func New(cfg map[string]string, metadata json.RawMessage) (providers.DNSServiceP
}
ctx := context.Background()
hc := config.Client(ctx)
dcli, err := gdns.New(hc)
// FIXME(tlim): Is it a problem that ctx is included with hc and in
// the call to NewService? Seems redundant.
dcli, err := gdns.NewService(ctx, option.WithHTTPClient(hc))
if err != nil {
return nil, err
}
Expand Down