New Dockerfile (fix #1459)

[fdcastel]

My first attempt to solve the Docker imbroglio. 😅

Based on the great work from @jauderho 👍

Fix #1459

[fdcastel]

Considerations:

• Based on v3.16.2 release
• Using golang 1.18 (it won't build wit 1.16)
• dnscontrol version ir returning dnscontrol v3.16.2-dev. I don't know if this is expected or if I need to pass any other parameters to build

[tlimoncelli]

Considerations:

• Based on v3.16.2 release

👍

• Using golang 1.18 (it won't build wit 1.16)

👍

• dnscontrol version ir returning dnscontrol v3.16.2-dev. I don't know if this is expected or if I need to pass any other parameters to build

Non-docker builds are done via go run build/build.go which embeds the version number (without -dev).

Tom

[fdcastel]

Rebased from master. Build ok.

[jauderho]

I would keep the FROM statements as listed in my Dockerfile. This pins the image to a specific digest which is best practices. Dependabot or Renovate can then be used to update the FROM statements as new images become available.

See an example pull request: https://github.com/jauderho/dockerfiles/pull/708/files

@tlimoncelli it looks like the -dev is actually set in pkg/version/version.go. I hacked it so that my Dockerfile sets -ldflags="-s -w -X main.SHA=${BUILD_VERSION}". Since we are tying this to tagged releases, it should be ok. Else the Dockerfile has to be updated to extract the specific git commit.

@fdcastel I have updated my Dockerfile accordingly. You might want to refactor.

[fdcastel]

@jauderho I believe I did all the changes you suggested. Please ping me if I missed something.

@tlimoncelli We still need someone versed in CircleCI to fix the current build system, right?

[jauderho]

LGTM

[tlimoncelli]

@tlimoncelli We still need someone versed in CircleCI to fix the current build system, right?

I may have misspoke earlier. Most of the build is on CircleCI now. So, adding the docker stuff shouldn't be too difficult. The person that did the last update is on vacation for 2 weeks, but I should be able to guess my way through it :-)

[tlimoncelli]

[Remember that I don't know a lot about Docker and DockerHub.]

It looks to me like the Dockerfile is ready to merge. I assume we'll have a different PR that modifies the .circleci files to build the container image and put it in a public repo so others can access it.

[aba-rechsteiner]

@fdcastel thank you for your work. But on docker hub it doesn't have a new image yet, is this no longer pushed to docker hub?

[fdcastel]

@aba-rechsteiner: It is not ready, yet.

As @tlimoncelli said we are waiting for the CircleCI maintainer, now.

Unfortunately I don't have any experience with CircleCI to help, in this case. 😞

[jauderho]

@fdcastel thank you for your work. But on docker hub it doesn't have a new image yet, is this no longer pushed to docker hub?

I have working images here and they are automatically built once upstream releases and tags. https://hub.docker.com/r/jauderho/dnscontrol/tags