Domainnameshop provider #1625
Merged
Domainnameshop provider #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 17, 2022 13:53
|
Hi there! Thanks for writing this up! The Linode provider has a similar situation with TTLs. You might take a look at how they handle that situation. Tom |
|
Thank you for the tip on the TTL issue. Weirdly now Not quite sure what the issue is. |
SimenBai
commented
Jul 18, 2022
|
Before we merge this I'd like to request that you reorganize the filenames (and move functions if needed). I know this is a big change, but doing it now is better than rewriting it all later. I'd really appreciate it! Thanks! |
|
I will look into that, do you have any suggestions for how to fix the issue I mentioned with 10:gentxt_TXT:Create_TXT_10? Not quite sure how to fix it, I might be mistaken, but isn't those two the same thing? If so, how can I go about fixing the records given from |
|
About gentxt_TXT:Create_TXT_10 : They are the same thing but the pkg/diff isn't smart enough to know that. If you call See how other providers use is: HTH |
|
|
|
Suggestion: Skip that test. Nobody depends on that behavior and I'm considering eliminating that test. |
|
Would another option potentially be to have a loop over i.e for _, rc := range dc.Records {
if rc.HasFormatIdenticalToTXT() {
rc.SetTargetTXT(strings.Join(rc.TxtStrings, ""))
}
} |
|
I think that might work. Give it a try! |
|
That made it pass the tests! |
|
All checks passed and I think it is restructured like you intended. |
tlimoncelli
approved these changes
Aug 1, 2022
|
Yup, should be ready to go |
|
Thanks for contributing the new provider! I'm excited to see this new addition! I'd like to have your email address in case Github has a problem. Can you send it to tlimoncelli at stack over flow dot com ? Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1611
Most tests pass, except for the
GeneralACDtests that change the TTLs as DomainNameShop only supports TTLs that are a multiple of 60 (i.e. TTL % 60 == 0). I am not quite sure what the best solution for handeling those instances. I am open for suggestions.Other than that there are a few features that can be added later. But I can create issues for them once this PR has been resolved.