MAINT: Refactor auditrecords.go to loop only once #1570 #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tresni @pragmaton @mikenz @Deraen @onlyhavecans @vojtad @Papakai @svenpeter42 @tlimoncelli @kordianbruck @costasd @MisterErwin @pgaskin Hey folks! I rewrote the record audit stuff to be significantly faster and less verbose. I believe I've converted the old code properly. Please take a look. |
|
Looks good for DNSimple! |
|
LGTM for the rwth provider (although it is a blatant copy of the other providers) |
tlimoncelli
changed the title
|
Flakey tests. They passed other times. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1570
The old AuditRecord does a lot of unneeded work. It loops through every record once for each test. This change loops through all the records once, calling checking functions appropriate to that record type. It also makes the format of the initializers readable.
I timed it on a small dataset and got a 1-3% improvement in total run time, I suspect that if I timed the function itself it would be more for providers that have many tests.