Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: Create a dynamic provider features matrix #201

Merged
merged 10 commits into from
Sep 14, 2017
Merged

docs: Create a dynamic provider features matrix #201

merged 10 commits into from
Sep 14, 2017

Conversation

captncraig
Copy link
Contributor

@captncraig captncraig commented Sep 14, 2017

2017-09-14 15_43_09-localhost_4000_provider-matrix

{"Official Support", "This means the provider is actively used at stack exchange, and we offer a stronger guarantee it will work"},
{"Registrar", "The provider has registrar capabilities to set nameservers for zones"},
{"DNS Provider", "Can manage and serve DNS zones"},
{"ALIAS", "Provider supports some kind of ALIAS,ANAME or flattened CNAME record type"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a space after the comma

matrix := &FeatureMatrix{
Providers: map[string]FeatureMap{},
Features: []FeatureDef{
{"Official Support", "This means the provider is actively used at stack exchange, and we offer a stronger guarantee it will work"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actively used at Stack Exchange, bugs are more likely to be fixed, and failing integration tests will block a release. See docs for details.

@captncraig captncraig merged commit 3a90435 into master Sep 14, 2017
@@ -19,6 +19,13 @@ type nameDotCom struct {
APIKey string `json:"apikey"`
}

var docNotes = providers.DocumentationNotes{
providers.DocDualHost: providers.Cannot("Apex NS records not editable"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apex NS records are editable, but they have to match the list of nameservers at the registry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's interesting @pmoroney. It creates a bit of a chicken and egg problem. In dnscontrol we update the dns provider first, and then the registrar. It sounds like that wouldn't work with NDC unless we invert that order?

We made that choice specifically so we never point at an uninitialized dns server.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dns provider ignores the Apex NS records and just lets the registrar provider handle it, so it doesn't really matter which order it works in. I do it for pat.irish using dnscontrol. I just removed it and re-added it and didn't have any problems.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that makes sense. Thats a slightly different paradigm than other providers, but it should work fine. I'll run a quick test and update the flag.

@captncraig captncraig changed the title Create a dynamic provider features matrix docs: Create a dynamic provider features matrix Sep 15, 2017
@tlimoncelli tlimoncelli deleted the matrix branch October 1, 2017 17:00
rblenkinsopp pushed a commit to rblenkinsopp/dnscontrol that referenced this pull request Aug 21, 2020
* adding simple provider feature matrix generator

* filling out matrix

* clean output

* dead code

* explanatory text

* explanatory text

* typo

* move stuff around

* clean

* editing
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants