Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

NEW RECORD TYPE: DNAME #2893

Merged
merged 1 commit into from
Apr 2, 2024
Merged

NEW RECORD TYPE: DNAME #2893

merged 1 commit into from
Apr 2, 2024

Conversation

imlonghao
Copy link
Contributor

close #2880

@imlonghao imlonghao changed the title NEW RECORD TYPE: DHCID NEW RECORD TYPE: DNAME Apr 1, 2024
@imlonghao imlonghao force-pushed the dname branch 2 times, most recently from abd5fdb to 9594409 Compare April 1, 2024 15:44
Copy link
Contributor

@tlimoncelli tlimoncelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!
Just a few minor suggestions.

documentation/functions/domain/DNAME.md Outdated Show resolved Hide resolved
pkg/js/parse_tests/047-DNAME.js Outdated Show resolved Hide resolved
pkg/js/parse_tests/047-DNAME.json Outdated Show resolved Hide resolved
integrationTest/integration_test.go Show resolved Hide resolved
@imlonghao imlonghao force-pushed the dname branch 2 times, most recently from 2b0954f to 8564de7 Compare April 2, 2024 13:49
@imlonghao
Copy link
Contributor Author

Test for cloudns

=== RUN   TestDNSProviders
=== RUN   TestDNSProviders/imlonghao.cloudns.asia
=== RUN   TestDNSProviders/imlonghao.cloudns.asia/Clean_Slate:Empty
=== RUN   TestDNSProviders/imlonghao.cloudns.asia/44:DNAME:Create_DNAME_record
    integration_test.go:236:
        + CREATE DNAME test.imlonghao.cloudns.asia example.com. ttl=300
=== RUN   TestDNSProviders/imlonghao.cloudns.asia/44:DNAME:Modify_DNAME_record
    integration_test.go:236:
        ± MODIFY DNAME test.imlonghao.cloudns.asia: (example.com. ttl=300) -> (example.net. ttl=300), ClouDNS ID: 482265345:
=== RUN   TestDNSProviders/imlonghao.cloudns.asia/44:DNAME:Create_DNAME_record_in_non-FQDN
    integration_test.go:236:
        - DELETE DNAME test.imlonghao.cloudns.asia example.net. ttl=300, ClouDNS ID: 482265345
    integration_test.go:236:
        + CREATE DNAME a.imlonghao.cloudns.asia b.imlonghao.cloudns.asia. ttl=300
--- PASS: TestDNSProviders (23.99s)
    --- PASS: TestDNSProviders/imlonghao.cloudns.asia (22.81s)
        --- PASS: TestDNSProviders/imlonghao.cloudns.asia/Clean_Slate:Empty (2.37s)
        --- PASS: TestDNSProviders/imlonghao.cloudns.asia/44:DNAME:Create_DNAME_record (5.98s)
        --- PASS: TestDNSProviders/imlonghao.cloudns.asia/44:DNAME:Modify_DNAME_record (6.11s)
        --- PASS: TestDNSProviders/imlonghao.cloudns.asia/44:DNAME:Create_DNAME_record_in_non-FQDN (7.17s)
=== RUN   TestDualProviders
    integration_test.go:337: Skipping.  DocDualHost == Cannot
--- SKIP: TestDualProviders (2.37s)
=== RUN   TestNameserverDots
    integration_test.go:401: Skipping.  DocDualHost == Cannot
--- SKIP: TestNameserverDots (2.38s)
PASS
ok  	github.com/StackExchange/dnscontrol/v4/integrationTest	29.165s

Test for bind

=== RUN   TestDNSProviders
=== RUN   TestDNSProviders/dnscontrol.net
=== RUN   TestDNSProviders/dnscontrol.net/Clean_Slate:Empty
File does not yet exist: "zones/dnscontrol.net.zone" (will create)
    integration_test.go:236:
        + CREATE dnscontrol.net SOA DEFAULT_NOT_SET. DEFAULT_NOT_SET. 3600 600 604800 1440 ttl=300
WRITING ZONEFILE: zones/dnscontrol.net.zone
=== RUN   TestDNSProviders/dnscontrol.net/44:DNAME:Create_DNAME_record
    integration_test.go:236:
        + CREATE test.dnscontrol.net DNAME example.com. ttl=300
WRITING ZONEFILE: zones/dnscontrol.net.zone
=== RUN   TestDNSProviders/dnscontrol.net/44:DNAME:Modify_DNAME_record
    integration_test.go:236:
        ± MODIFY test.dnscontrol.net DNAME (example.com. ttl=300) -> (example.net. ttl=300)
WRITING ZONEFILE: zones/dnscontrol.net.zone
=== RUN   TestDNSProviders/dnscontrol.net/44:DNAME:Create_DNAME_record_in_non-FQDN
    integration_test.go:236:
        + CREATE a.dnscontrol.net DNAME b.dnscontrol.net. ttl=300
        - DELETE test.dnscontrol.net DNAME example.net. ttl=300
WRITING ZONEFILE: zones/dnscontrol.net.zone
--- PASS: TestDNSProviders (0.01s)
    --- PASS: TestDNSProviders/dnscontrol.net (0.01s)
        --- PASS: TestDNSProviders/dnscontrol.net/Clean_Slate:Empty (0.00s)
        --- PASS: TestDNSProviders/dnscontrol.net/44:DNAME:Create_DNAME_record (0.00s)
        --- PASS: TestDNSProviders/dnscontrol.net/44:DNAME:Modify_DNAME_record (0.00s)
        --- PASS: TestDNSProviders/dnscontrol.net/44:DNAME:Create_DNAME_record_in_non-FQDN (0.00s)
=== RUN   TestDualProviders
    integration_test.go:358: Clearing everything
    integration_test.go:352: #1:
        - DELETE a.dnscontrol.net DNAME b.dnscontrol.net. ttl=300
WRITING ZONEFILE: zones/dnscontrol.net.zone
    integration_test.go:365: Adding nameservers from another provider
    integration_test.go:352: #1:
        + CREATE dnscontrol.net NS ns1.example.com. ttl=300
        + CREATE dnscontrol.net NS ns2.example.com. ttl=300
WRITING ZONEFILE: zones/dnscontrol.net.zone
    integration_test.go:368: Running again to ensure stability
--- PASS: TestDualProviders (0.00s)
=== RUN   TestNameserverDots
=== RUN   TestNameserverDots/No_trailing_dot_in_nameserver
--- PASS: TestNameserverDots (0.00s)
    --- PASS: TestNameserverDots/No_trailing_dot_in_nameserver (0.00s)
PASS
ok  	github.com/StackExchange/dnscontrol/v4/integrationTest	0.384s

@imlonghao imlonghao marked this pull request as ready for review April 2, 2024 14:01
@tlimoncelli
Copy link
Contributor

Fantastic!

Thank you so much! Many people have requested this feature! I'm sure they'll be very happy!

@tlimoncelli tlimoncelli merged commit 42125b5 into StackExchange:main Apr 2, 2024
5 of 6 checks passed
tlimoncelli added a commit that referenced this pull request Apr 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DNAME support
2 participants