Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

NETLIFY: Enable cmode concurrent #3205

Merged
merged 2 commits into from
Nov 20, 2024
Merged

NETLIFY: Enable cmode concurrent #3205

merged 2 commits into from
Nov 20, 2024

Conversation

willpower232
Copy link
Contributor

As per #3202, I believe Netlify works with concurrency

@tlimoncelli
Copy link
Contributor

CC @SphericalKat (provider owner)

Looking at the code, this should work fine.

If you'd like to verify empirically, please do the following:

  1. Compile with the -race flag: go install -race
  2. Run with a dnsconfig.js that has multiple domains from this provider (4 or more is preferable)
  3. Run "dnscontrol preview --cmode concurrent` two or three times. You should get zero race condition errors

@SphericalKat
Copy link
Contributor

Thanks for the PR! I'll run some tests in a bit and get back 👀

SphericalKat
SphericalKat approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@SphericalKat SphericalKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by both myself and a few other users, everything seems good!

@tlimoncelli
Copy link
Contributor

Great! Thanks!

@tlimoncelli tlimoncelli merged commit d29c1cf into StackExchange:main Nov 20, 2024
2 checks passed
KaiSchwarz-cnic pushed a commit to centralnicgroup-opensource/rtldev-middleware-dnscontrol that referenced this pull request Dec 6, 2024
@willpower232 @KaiSchwarz-cnic
NETLIFY: Enable cmode concurrent (StackExchange#3205)
b564ef3
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@SphericalKat SphericalKat SphericalKat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willpower232 @tlimoncelli @SphericalKat