Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DIGITALOCEAN: Enable cmode concurrent #3207

Merged

Conversation

willpower232
Copy link
Contributor

As per #3202, I believe DigitalOcean works with concurrency

@tlimoncelli tlimoncelli merged commit 2eeeb76 into StackExchange:main Nov 19, 2024
tlimoncelli added a commit that referenced this pull request Nov 19, 2024
@tlimoncelli
Copy link
Contributor

CC @Deraen (provider owner)

(I merge this prematurely. Sorry! Anyway... if you have time, please verify this change.)

Looking at the code, this should work fine.

If you'd like to verify empirically, please do the following:

  1. Compile with the -race flag: go install -race
  2. Run with a dnsconfig.js that has multiple domains from this provider (4 or more is preferable)
  3. Run "dnscontrol preview --cmode concurrent` two or three times. You should get zero race condition errors

@willpower232
Copy link
Contributor Author

@tlimoncelli I forgot the docs sorry, if you've reverted should I make a fresh PR with the docs?

@tlimoncelli
Copy link
Contributor

Don't worry about the docs. I run "go generate" as part of the release process.

KaiSchwarz-cnic pushed a commit to centralnicgroup-opensource/rtldev-middleware-dnscontrol that referenced this pull request Dec 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants