Add notifications with Shoutrr #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmoffatt
force-pushed
the
notify-shoutrrr
branch
from
d36ad95 to
de79f48
Compare
tlimoncelli
reviewed
Nov 27, 2024
pkg/notifications/shoutrrr.go
Outdated
| }) | ||
| } | ||
|
|
||
| // bonfire notifier for stack exchange internal chat. String is just url with room and token in it |
There was a problem hiding this comment.
Suggestion: Delete this comment.
|
I've tested this with Matrix and ntfy, and it works like a charm! |
hmoffatt
force-pushed
the
notify-shoutrrr
branch
from
de79f48 to
8aacf63
Compare
hmoffatt
force-pushed
the
notify-shoutrrr
branch
from
8aacf63 to
24ffe20
Compare
|
I've added documentation now. |
cafferata
suggested changes
Dec 4, 2024
Co-authored-by: Jeffrey Cafferata <jeffrey@jcid.nl>
cafferata
approved these changes
Dec 5, 2024
tlimoncelli
reviewed
Dec 9, 2024
|
Thank you for adding this! I didn't know Shoutrr existed. This should be the way we do all notifications in the future. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to update the documentation, but this seems to work for me. Resolves #2994 .
Ideally the notifiers would all use a common formatter (or at least a common format), as there's slight differences in the format of the messages between each currently.
The custom notifiers for Slack/Teams/Telegram could be refactored to use Shoutrrr too, though there's so little code it's probably not worth it.