Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CHORE: Remediate staticcheck warnings #3231

Merged
merged 4 commits into from
Dec 9, 2024
Merged

CHORE: Remediate staticcheck warnings #3231

merged 4 commits into from
Dec 9, 2024

Conversation

tlimoncelli
Copy link
Contributor

@tlimoncelli tlimoncelli commented Dec 9, 2024

Problem:

staticcheck reports these issues:

pkg/js/hash.go:20:2: this value of result is never used (SA4006)
providers/autodns/autoDnsProvider.go:101:14: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
providers/dnsimple/dnsimpleProvider.go:732:9: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
providers/hedns/hednsProvider.go:693:9: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
providers/oracle/oracleProvider.go:180:16: error strings should not be capitalized (ST1005)
providers/oracle/oracleProvider.go:180:16: error strings should not end with punctuation or newlines (ST1005)

golint reports:

providers/cnr/cnrProvider.go:1:1: package comment should be of the form "Package cnr ..."
providers/porkbun/api.go:89:3: should replace retrycnt += 1 with retrycnt++

Solution:

Fix them.

@tlimoncelli tlimoncelli changed the title Tlim linting CHORE: Fix staticcheck warnings Dec 9, 2024
@tlimoncelli tlimoncelli changed the title CHORE: Fix staticcheck warnings CHORE: Remediate staticcheck warnings Dec 9, 2024
@tlimoncelli
Copy link
Contributor Author

CC @arnoschoon @onlyhavecans @rblenkinsopp @kallsyms for visibility.

@tlimoncelli
Copy link
Contributor Author

CC @AsifNawaz-cnic @KaiSchwarz-cnic for visibility

@KaiSchwarz-cnic
Copy link
Contributor

KaiSchwarz-cnic commented Dec 9, 2024

@tlimoncelli my pardon if checks failed - I was playing with integration tests in parallel and missed using a different test domain and by that we both run into collisions. I'll switch our side now to something different.

I'll have an eye on the static check issue as well and will open a PR tomorrow.

@tlimoncelli
Copy link
Contributor Author

@KaiSchwarz-cnic Colliding over the same domain is great news! I was worried it was something deeper! What a relief!

I'll merge this and that should take care of the issues staticcheck listed for CNR.

@tlimoncelli tlimoncelli merged commit 9357743 into main Dec 9, 2024
17 checks passed
@tlimoncelli tlimoncelli deleted the tlim_linting branch December 9, 2024 22:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants