TRANSIP: Pause when rate-limited #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not perfect, but its a good start. Thoughts? |
|
Sorry for rushing this but I'm trying to get a few things merged before I do a full release. I'm going to merge this. We can always "roll forward" if other changes are needed. |
Sure, The only real gripes I have with it is the use of |
|
Yeah, I'm not in love with Tom
|
tlimoncelli
added a commit
that referenced
this pull request
Jan 21, 2025
commit 901a3ac Author: Tom Limoncelli <tlimoncelli@stackoverflow.com> Date: Tue Jan 21 14:43:33 2025 -0500 CHORE: Update dependencies (#3397) commit 70e9659 Author: Tom Limoncelli <tlimoncelli@stackoverflow.com> Date: Tue Jan 21 14:29:53 2025 -0500 MSDNS: Provider is failing due to lint fix gone wrong (#3396) commit 5e15bbe Author: Jakob Ackermann <das7pad@outlook.com> Date: Sat Jan 18 13:54:37 2025 +0000 BUG: fetch zones once in ZoneCache (#3394) commit a631c5b Author: Kai Schwarz <kai.schwarz@centralnic.com> Date: Fri Jan 17 20:15:10 2025 +0100 CNR: Initial Performance improvement; golint review (#3391) commit e1c9785 Author: Tom Limoncelli <tlimoncelli@stackoverflow.com> Date: Fri Jan 17 07:11:10 2025 -0500 CHORE: Update dependencies (#3385) commit 9e88b6a Author: Tom Limoncelli <tlimoncelli@stackoverflow.com> Date: Thu Jan 16 21:47:10 2025 -0500 CICD: Make pager tests more visible (#3387) commit 67db0e2 Author: Tom Limoncelli <tlimoncelli@stackoverflow.com> Date: Thu Jan 16 14:41:18 2025 -0500 GCLOUD: remove (irrelevant) slow test (#3384) commit c348e35 Author: Tom Limoncelli <tlimoncelli@stackoverflow.com> Date: Thu Jan 16 14:32:32 2025 -0500 GCLOUD: CICD: Skip the pager1201 integration test (#3383) commit 5cfb907 Author: Tom Limoncelli <tlimoncelli@stackoverflow.com> Date: Thu Jan 16 14:17:47 2025 -0500 TRANSIP: Pause when rate-limited (#3378) commit f666af8 Author: Tom Limoncelli <tlimoncelli@stackoverflow.com> Date: Thu Jan 16 13:56:46 2025 -0500 GCLOUD: Re-try on 502 errors (#3376) commit 1a1a4bf Author: Tom Limoncelli <tlimoncelli@stackoverflow.com> Date: Thu Jan 16 12:54:48 2025 -0500 INWX: Enable SRV to have "." target (#3380) commit 3556439 Author: Tom Limoncelli <tlimoncelli@stackoverflow.com> Date: Thu Jan 16 10:58:11 2025 -0500 CLOUDFLAREAPI: No longer treat TTL=300 as special (#3368) Co-authored-by: Sukka <github@skk.moe> commit 89c65b6 Author: Tom Limoncelli <tlimoncelli@stackoverflow.com> Date: Thu Jan 16 10:03:00 2025 -0500 INWX: Permit "." target for SRV records (#3377) commit fc2c506 Author: Tom Limoncelli <tlimoncelli@stackoverflow.com> Date: Wed Jan 15 18:28:15 2025 -0500 CICD: Warn user if -provider does not match profiles.json:TYPE (#3375) commit 0d5b3c2 Author: Jakob Ackermann <das7pad@outlook.com> Date: Wed Jan 15 22:43:24 2025 +0000 CLOUDFLARE: adopt ZoneCache (#3373) commit 2ef2362 Author: Jakob Ackermann <das7pad@outlook.com> Date: Wed Jan 15 20:23:02 2025 +0000 HETZNER: adopt ZoneCache (#3372) commit ab00797 Author: Tom Hughes <tom@compton.nu> Date: Wed Jan 15 02:07:19 2025 +0000 FEATURE: Extend PTR magic handling to support RFC4183 names (#3364) commit 5c9b170 Author: Jakob Ackermann <das7pad@outlook.com> Date: Wed Jan 15 02:05:17 2025 +0000 FEAT: Add ZoneCache primitive (#3365)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3371
Issue
TRANSIP doesn't retry on rate limit (429) requests.
Resolution
Add retry logic for all API calls.