This repository has been archived by the owner on Jan 22, 2022. It is now read-only.
fix support for slices #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Looks like previous PR #38 breaks functionality from PR #19. String arrays, like IP addreses from Win32_NetworkAdapterConfiguration are empty now.
I've tried to understand what's wrong and found, that prop.Value() for array is nil, but prop type is VT_ARRAY, so I've changed condition to check if prop is actually VT_NULL.
It works on my machine (c), but I'm not a golang guru, so please double check, if I break something else.