Use correct gunicorn logging config with st2 packages (don't include AUDIT log messages in non-AUDIT log file) #4621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not doing that means change / fix in #4538 won't work since regular config which includes DEBUG and AUDIT will be used over gunicorn one.
1 task
jinpingh
approved these changes
Apr 10, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing some other changes, I noticed fix in #4538 doesn't appear to be working in production with packages.
It turns out we were not using correct gunicorn logging config with StackStorm packages (gunicorn config makes sure DEBUG and non-audit log messages don't end up in non-audit service log file bi default).
Related PR: StackStorm/st2-packages#607