Move ManagedAsynchronousAccess to SpeziFoundation #47
Labels
enhancement
New feature or request
Comments
Merged
1 task
Supereg
added a commit
to StanfordSpezi/SpeziFoundation
that referenced
this issue
Oct 17, 2024
# Introduce RWLock, ManagedAsynchronousAccess and DataDescriptor ## ♻️ Current situation & Problem This PR adds the `RWLock`, `RecursiveRWLock` and `ManagedAsynchronousAccess` infrastructure that was previously introduced in SpeziBluetooth (see StanfordSpezi/SpeziBluetooth#45 and StanfordSpezi/SpeziBluetooth#47). This changes require the Swift 6 toolchain. Therefore, we increase the required swift tools version to 6.0. This PR introduces the final changes for the SpeziFoundation 2.0 release (assuming #16 is merged beforehand). ## ⚙️ Release Notes * Added `RWLock` and `RecursiveRWLock` * Added `ManagedAsynchronousAccess` * Only require `sending` closure with `withTimeout` instead of a `@Sendable` one. * Add new `DataDescriptor` type. ## 📚 Documentation Updated the documentation catalog, adding a new "Concurrency" topics section. ## ✅ Testing Added unit test for the new components. ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Problem
We introduced the
ManagedAsynchronousAccesstype to easily create a continuation that is protected by anAsyncSemaphore. This type is currently internal and cannot be reused across the framework ecosystem.Solution
Move this type to the SpeziFoundation package. ideally, we wait for until Spezi enforces the Swift 6 toolchain as it introduces actor inheritance for async method calls. This way we can have the
performmethods inherit actor isolation, executing the action on the same Task and not requiring a global actor annotation.Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: