Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add PLX (Pulse Oximeter) support #54

Merged
merged 4 commits into from
Nov 30, 2024

fix missing change

12243f5
Select commit
Loading
Failed to load commit list.
Merged

Add PLX (Pulse Oximeter) support #54

fix missing change
12243f5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 30, 2024 in 0s

80.98% (+0.87%) compared to 22e7dcf

View this Pull Request on Codecov

80.98% (+0.87%) compared to 22e7dcf

Details

Codecov Report

Attention: Patch coverage is 89.78102% with 28 lines in your changes missing coverage. Please review.

Project coverage is 80.98%. Comparing base (22e7dcf) to head (12243f5).

Files with missing lines Patch % Lines
...luetoothServices/Characteristics/PLXFeatures.swift 81.49% 10 Missing ⚠️
...ices/Characteristics/PLXSpotCheckMeasurement.swift 88.64% 10 Missing ⚠️
...ces/Characteristics/PLXContinuousMeasurement.swift 93.90% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   80.11%   80.98%   +0.87%     
==========================================
  Files         111      115       +4     
  Lines        6053     6327     +274     
==========================================
+ Hits         4849     5123     +274     
  Misses       1204     1204              
Files with missing lines Coverage Δ
...etoothServices/Services/PulseOximeterService.swift 100.00% <100.00%> (ø)
...luetoothServices/Services/WeightScaleService.swift 100.00% <ø> (ø)
...ces/Characteristics/PLXContinuousMeasurement.swift 93.90% <93.90%> (ø)
...luetoothServices/Characteristics/PLXFeatures.swift 81.49% <81.49%> (ø)
...ices/Characteristics/PLXSpotCheckMeasurement.swift 88.64% <88.64%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22e7dcf...12243f5. Read the comment docs.