added function to track active users #23
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 82.04% 81.65% -0.39%
==========================================
Files 16 16
Lines 1609 1618 +9
==========================================
+ Hits 1320 1321 +1
- Misses 289 297 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Hi @ArnavS59,
Thank you for your contribution! I have a few suggestions:
- Consider using string constants for the column names within your function. This can help with readability and future code maintenance.
- Please take a moment to address the linting errors.
- It would be helpful to add a unit test for your function.
| return | ||
|
|
||
| #First convert column to datetime for comparison | ||
| flattend_fhir_df['EffectiveDateTime'] = pd.to_datetime(flattend_fhir_df['EffectiveDateTime'], format='%d.%m.%y') |
There was a problem hiding this comment.
Consider replacing the string column name with a constant already declared for all column names in FHIRDataframe
| flattend_fhir_df['EffectiveDateTime'] = pd.to_datetime(flattend_fhir_df['EffectiveDateTime'], format='%d.%m.%y') | ||
| #Filter the most recent entry for each userid | ||
| most_recent_df=flattend_fhir_df.loc[flattend_fhir_df.groupby('UserId')['EffectiveDateTime'].idxmax()] | ||
| most_recent_df=most_recent_df[['UserId','EffectiveDateTime']]#select the relevant cols |
There was a problem hiding this comment.
Same comment here for "UserID" and "EffectiveDateTime".
| most_recent_df=flattend_fhir_df.loc[flattend_fhir_df.groupby('UserId')['EffectiveDateTime'].idxmax()] | ||
| most_recent_df=most_recent_df[['UserId','EffectiveDateTime']]#select the relevant cols | ||
| most_recent_df.rename(columns={'EffectiveDateTime': 'LastUserInteraction'}, inplace=True) | ||
| most_recent_df.to_csv('output.csv') |
There was a problem hiding this comment.
Another suggestion would be to allow the user of the spezi-data-pipeline package to set the name of the output file by themselves.
| @@ -313,3 +313,24 @@ def select_data_by_dates( # pylint: disable=unused-variable | |||
| filtered_df.reset_index(drop=True), | |||
| resource_type=flattened_fhir_dataframe.resource_type, | |||
| ) | |||
|
|
|||
| def extract_latest_user_interaction( # pylint: disable=unused-variable | |||
| flattend_fhir_df: pd.DataFrame | |||
There was a problem hiding this comment.
In the spezi-data-pipeline package, the functionalities are built around FHIRDataFrame objects. You might want to adjust your function to receive FHIRDataFrame as an input argument.
Track active users in DB
♻️ Current situation & Problem
PR for #17
⚙️ Release Notes
extract_latest_user_interactiontodata_processor.pyto track active users in the DB.📚 Documentation
Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.
✅ Testing
Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: