Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade Spezi to 0.8.0 and move to Observable #13

Merged
merged 4 commits into from
Nov 11, 2023
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Nov 10, 2023

Upgrade Spezi to 0.8.0 and move to Observable

♻️ Current situation & Problem

This PR upgrades Spezi to the latest 0.8.0 release. Further, we migrate our codebase to use the new observation framework.

⚙️ Release Notes

  • Migrate to Observation
  • Updated Spezi to 0.8.0

📚 Documentation

Minor fixes in the documentation.

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #13 (7d5ef67) into main (f8f6645) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   71.79%   71.99%   +0.20%     
==========================================
  Files          11       11              
  Lines         436      439       +3     
==========================================
+ Hits          313      316       +3     
  Misses        123      123              
Files Coverage Δ
...s/SpeziHealthKit/CollectSample/CollectSample.swift 100.00% <ø> (ø)
.../SpeziHealthKit/CollectSample/CollectSamples.swift 100.00% <ø> (ø)
...hKit/CollectSample/HealthKitSampleDataSource.swift 96.33% <100.00%> (ø)
...Extensions/HKHealthStore+AnchoredObjectQuery.swift 85.19% <100.00%> (ø)
Sources/SpeziHealthKit/HealthKit.swift 88.89% <100.00%> (+0.49%) ⬆️
...hKitDeliverySetting/HealthKitDeliverySetting.swift 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f6645...7d5ef67. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Supereg!

@Supereg Supereg merged commit 30e12a0 into main Nov 11, 2023
@Supereg Supereg deleted the feature/upgrade-spezi branch November 11, 2023 22:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants