Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes Crashing When Using Background Requests #16

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

PSchmiedmayer
Copy link
Member

Fixes Crashing When Using Background Requests

♻️ Current situation & Problem

  • if a developer uses multiple HealthKit queries in the background data races accessing the tracked background activations can lead to runtime crashes.

⚙️ Release Notes

  • Fixes the issue using additional locking mechanisms

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer added bug Something isn't working enhancement New feature or request labels Feb 20, 2024
@PSchmiedmayer PSchmiedmayer self-assigned this Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (d882734) 70.20% compared to head (f1a64a7) 69.90%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   70.20%   69.90%   -0.30%     
==========================================
  Files          11       11              
  Lines         453      455       +2     
==========================================
  Hits          318      318              
- Misses        135      137       +2     
Files Coverage Δ
...lthKit Extensions/HKHealthStore+Observations.swift 68.58% <17.65%> (-2.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d882734...f1a64a7. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit b40695f into main Feb 20, 2024
7 of 9 checks passed
@PSchmiedmayer PSchmiedmayer deleted the fixAsyncAccess branch February 20, 2024 02:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant