-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support Strict Concurrency #23
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 70.16% 71.83% +1.68%
==========================================
Files 11 11
Lines 459 465 +6
==========================================
+ Hits 322 334 +12
+ Misses 137 131 -6
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the work here; very nice to see the updates in this package! 🚀
Support Strict Concurrency
♻️ Current situation & Problem
This PR updates SpeziHealthKit to enable strict concurrency checking and provides compatibility with Swift 6.
NSPredicate is not Sendable (see a discussion here). Therefore,
CollectSample
andCollectSamples
cannot beSendable
. These types are usually constructed in the configuration section which runs on the MainActor. Therefore, instances ofCollectSample
, ... can never leave the@MainActor
. This is why this PR constraints a lot of the implementation to the MainActor.⚙️ Release Notes
📚 Documentation
--
✅ Testing
--
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: