Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix isFullyAuthorized #36

Merged
merged 2 commits into from
Feb 20, 2025
Merged

fix isFullyAuthorized #36

merged 2 commits into from
Feb 20, 2025

Conversation

lukaskollmer
Copy link
Member

fix isFullyAuthorized

♻️ Current situation & Problem

  • Problem: the isFullyAuthorized property is currently only updated when the app explicitly calls one of the askForAuthorization methods. This is bad bc it might not always happen. Plus, there can be cases where an app has already asked for authorization in the past, and technically doesn't need to do so anymore.
  • Solution: We update the property in more cases, to make sure its value is correct in more situations.

⚙️ Release Notes

  • fix isFullyAuthorized sometimes not being updated if the application doesn't call askForAuthorization

📚 Documentation

n/a

✅ Testing

n/a

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@lukaskollmer lukaskollmer added the enhancement New feature or request label Feb 20, 2025
@lukaskollmer lukaskollmer enabled auto-merge (squash) February 20, 2025 17:45
@lukaskollmer lukaskollmer enabled auto-merge (squash) February 20, 2025 18:23
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.82%. Comparing base (837979e) to head (a4511cd).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #36       +/-   ##
===========================================
+ Coverage   72.72%   83.82%   +11.11%     
===========================================
  Files          45       45               
  Lines        2624     2626        +2     
===========================================
+ Hits         1908     2201      +293     
+ Misses        716      425      -291     
Files with missing lines Coverage Δ
Sources/SpeziHealthKit/HealthKit.swift 76.53% <100.00%> (+0.65%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 837979e...a4511cd. Read the comment docs.

@lukaskollmer lukaskollmer merged commit 35e4a4a into main Feb 20, 2025
9 of 10 checks passed
@lukaskollmer lukaskollmer deleted the lukas/fix-isFullyAuthorized branch February 20, 2025 21:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants