-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
String resources #81
Labels
enhancement
New feature or request
Comments
Would be great; localization is up on the agenda after the cross-institution launch. We should ensure that we have the bits and pieces in place for that. |
eldcn
added a commit
that referenced
this issue
Sep 20, 2024
# Deletion of records ## What is done - Unify weight, blood pressure and heart rate view models into one `HeartRateViewModel` to avoid duplicated logic - Add confirmation alert for record deletion health tabs - Unit test view model - Added `StringResource` type to handle string properties of ui state models (proposed in #81) ## ⚙️ Release Notes *Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.* *Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.* ## 📚 Documentation *Please ensure that you properly document any additions in conformance to [Spezi Documentation Guide](https://github.com/StanfordSpezi/.github/blob/main/DOCUMENTATIONGUIDE.md).* *You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.* ## ✅ Testing *Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.* *This section describes important information about the tests and why some elements might not be testable.* ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [ ] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Problem
Currently we are defining string resource in
.kt
files which makes it hard to handle localizationSolution
values/strings.xml
of either app or the module owning the resourceShow Context Actions
>Extract string resource
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: