Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ensure access to PDFDocument is always concurrency safe #58

Merged
merged 8 commits into from
Jan 21, 2025

fix

e138487
Select commit
Loading
Failed to load commit list.
Merged

Ensure access to PDFDocument is always concurrency safe #58

fix
e138487
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 21, 2025 in 0s

71.06% (+0.19%) compared to 411494e

View this Pull Request on Codecov

71.06% (+0.19%) compared to 411494e

Details

Codecov Report

Attention: Patch coverage is 78.37838% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.06%. Comparing base (411494e) to head (e138487).

Files with missing lines Patch % Lines
Sources/SpeziOnboarding/OnboardingDataSource.swift 36.37% 7 Missing ⚠️
.../SpeziOnboarding/ConsentView/ConsentDocument.swift 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   70.87%   71.06%   +0.19%     
==========================================
  Files          27       27              
  Lines        1318     1323       +5     
==========================================
+ Hits          934      940       +6     
+ Misses        384      383       -1     
Files with missing lines Coverage Δ
...sentView/ConsentDocument+ExportConfiguration.swift 58.83% <100.00%> (ø)
...ing/ConsentView/ConsentDocumentExport+Export.swift 98.96% <ø> (ø)
...Onboarding/ConsentView/ConsentDocumentExport.swift 100.00% <100.00%> (+25.00%) ⬆️
...ConsentView/OnboardingConsentView+ShareSheet.swift 0.00% <ø> (ø)
.../SpeziOnboarding/ConsentView/ConsentDocument.swift 82.40% <0.00%> (ø)
Sources/SpeziOnboarding/OnboardingDataSource.swift 29.73% <36.37%> (-5.75%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 411494e...e138487. Read the comment docs.