Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[BugFix] enable http/1.1 when proxying http request for FE #53010

Merged
merged 1 commit into from
Nov 20, 2024
Merged

[BugFix] enable http/1.1 when proxying http request for FE #53010

merged 1 commit into from
Nov 20, 2024

Conversation

kevincai
Copy link
Contributor

Why I'm doing:

What I'm doing:

Refs #52998

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@kevincai
[BugFix] enable http/1.1 when proxying http request for FE
cc6230c 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
@kevincai kevincai requested a review from a team as a code owner November 19, 2024 12:06
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@banmoy
Copy link
Contributor

banmoy commented Nov 19, 2024 •
edited
Loading

Is this issue from the real use case? I haven't met this exception before.

@kevincai
Copy link
Contributor Author

Is this issue from the real use case? I haven't met this exception before.

Introduced in line https://github.com/StarRocks/starrocks/pull/52582/files#diff-4fc2b2317e41e62c2dbbde01b47588b8b582fa39e29a74f2eeddc2b8b0533666R99

It enforces a strict check of Expect header with http version in context.

@alvin-celerdata alvin-celerdata merged commit 10dcbd7 into StarRocks:main Nov 20, 2024
49 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Nov 20, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 20, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 20, 2024
@kevincai @mergify
[BugFix] enable http/1.1 when proxying http request for FE (#53010)
147677e 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit 10dcbd7)
@mergify mergify bot mentioned this pull request Nov 20, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Nov 20, 2024
@kevincai @mergify
[BugFix] enable http/1.1 when proxying http request for FE (#53010)
b79e75c 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit 10dcbd7)
mergify bot pushed a commit that referenced this pull request Nov 20, 2024
@kevincai @mergify
[BugFix] enable http/1.1 when proxying http request for FE (#53010)
40bd786 
Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
(cherry picked from commit 10dcbd7)
This was referenced Nov 20, 2024
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request Nov 20, 2024
@mergify @kevincai
[BugFix] enable http/1.1 when proxying http request for FE (backport #…
861d3ef 
…53010) (#53024)

Co-authored-by: Kevin Cai <caixiaohua@starrocks.com>
wanpengfei-git pushed a commit that referenced this pull request Nov 20, 2024
@mergify @kevincai
[BugFix] enable http/1.1 when proxying http request for FE (backport #…
8bdb3cd 
…53010) (#53026)

Co-authored-by: Kevin Cai <caixiaohua@starrocks.com>
wanpengfei-git pushed a commit that referenced this pull request Nov 20, 2024
@mergify @kevincai
[BugFix] enable http/1.1 when proxying http request for FE (backport #…
9713f91 
…53010) (#53025)

Co-authored-by: Kevin Cai <caixiaohua@starrocks.com>
@yandongxiao yandongxiao mentioned this pull request Nov 20, 2024
Merged
Smith-Cruise pushed a commit to Smith-Cruise/starrocks that referenced this pull request Nov 26, 2024
@kevincai @Smith-Cruise
[BugFix] enable http/1.1 when proxying http request for FE (StarRocks…
b0824ff 
…#53010)

Signed-off-by: Kevin Xiaohua Cai <caixiaohua@starrocks.com>
@kevincai kevincai deleted the nginx-deafult-http11 branch December 30, 2024 02:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alvin-celerdata alvin-celerdata alvin-celerdata approved these changes

@banmoy banmoy banmoy approved these changes

@wyb wyb wyb approved these changes

Assignees

@kevincai kevincai

Labels
3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevincai @banmoy @wyb @alvin-celerdata