Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BugFix] Fix runtime filter crash with aggregate query cache (backport #54305) #54317

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 25, 2024

Why I'm doing:

since #52625 support evaluate runtime bloom filter in aggregate. but in multi count distinct pre_cache agg shouldn't call evaluate runtime filter

*** Aborted at 1735093602 (unix time) try "date -d @1735093602" if you are using GNU date ***
PC: @          0x5e51e1b starrocks::RuntimeFilterProbeCollector::compute_hash_values(starrocks::Chunk*, starrocks::Column*, starrocks::RuntimeFilterProbeDescriptor*, starrocks::RuntimeBloomFilterEvalContext&)
*** SIGSEGV (@0x0) received by PID 32678 (TID 0x7ef5389e6640) from PID 0; stack trace: ***
    @     0x7f0bf90a919f __pthread_once_slow
    @          0x7bc0c00 google::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*)
    @     0x7f0bf90ac1d0 (/usr/lib64/[libpthread-2.32.so](http://libpthread-2.32.so/)+0x141cf)
    @          0x5e51e1b starrocks::RuntimeFilterProbeCollector::compute_hash_values(starrocks::Chunk*, starrocks::Column*, starrocks::RuntimeFilterProbeDescriptor*, starrocks::RuntimeBloomFilterEvalContext&)
    @          0x5e520b2 starrocks::RuntimeFilterProbeCollector::update_selectivity(starrocks::Chunk*, starrocks::RuntimeBloomFilterEvalContext&)
    @          0x5e5308f starrocks::RuntimeFilterProbeCollector::evaluate(starrocks::Chunk*, starrocks::RuntimeBloomFilterEvalContext&)
    @          0x42ccc4b starrocks::pipeline::Operator::eval_runtime_bloom_filters(starrocks::Chunk*)
    @          0x4399fcd starrocks::pipeline::AggregateDistinctBlockingSourceOperator::pull_chunk(starrocks::RuntimeState*)
    @          0x4402d15 starrocks::query_cache::ConjugateOperator::pull_chunk(starrocks::RuntimeState*)
    @          0x43f8c6c starrocks::query_cache::MultilaneOperator::_pull_chunk_from_lane(starrocks::RuntimeState*, starrocks::query_cache::MultilaneOperator::Lane&, bool)
    @          0x43f90f5 starrocks::query_cache::MultilaneOperator::pull_chunk(starrocks::RuntimeState*)
    @          0x4372b9b starrocks::pipeline::PipelineDriver::process(starrocks::RuntimeState*, int)
    @          0x4634ab3 starrocks::pipeline::GlobalDriverExecutor::_worker_thread()
    @          0x3844623 starrocks::ThreadPool::dispatch_thread()
    @          0x383d086 starrocks::Thread::supervise_thread(void*)
    @     0x7f0bf90a13fb start_thread
    @     0x7f0bf8ef9e83 __GI___clone

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: stdpain <drfeng08@gmail.com>
(cherry picked from commit 76cd9ab)
@wanpengfei-git wanpengfei-git merged commit 759ab18 into branch-3.2 Dec 25, 2024
32 of 33 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-54305 branch December 25, 2024 07:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants