Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BugFix]If cancelled by be add query_ctx into sc_map #56663

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zombee0
Copy link
Contributor

@zombee0 zombee0 commented Mar 6, 2025

Why I'm doing:

in ExecEnv::GetInstance()->query_context_mgr()->remove(_query_id);
we will extend lifetime by adding query_ctx into the sc_map, we do that
for the upcoming fragments, but if query is cancelled by be, we don't
know if there are upcoming fragments, so we need skip the check on
it->second->is_dead(), and give it the second chance.

What I'm doing:

Fixes #issue
https://github.com/StarRocks/StarRocksTest/issues/9345

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Signed-off-by: zombee0 <ewang2027@gmail.com>
@zombee0 zombee0 requested a review from a team as a code owner March 6, 2025 08:11
@mergify mergify bot assigned zombee0 Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Mar 6, 2025

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Mar 6, 2025

[BE Incremental Coverage Report]

pass : 8 / 8 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/pipeline/pipeline_driver_executor.cpp 1 1 100.00% []
🔵 be/src/exec/pipeline/query_context.h 3 3 100.00% []
🔵 be/src/service/internal_service.cpp 1 1 100.00% []
🔵 be/src/exec/pipeline/query_context.cpp 3 3 100.00% []

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants