Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Bug]: Search bar on homepage doesn't work with collapsible menus #2264

Closed
1 task done
Frooodle opened this issue Nov 18, 2024 · 3 comments · Fixed by #2277
Closed
1 task done

[Bug]: Search bar on homepage doesn't work with collapsible menus #2264

Frooodle opened this issue Nov 18, 2024 · 3 comments · Fixed by #2277
Assignees
@omar-ahmed42
Labels
Bug Something isn't working enhancement New feature or request Front End Issues or pull requests related to front-end development good first issue Good for newcomers

Comments

@Frooodle
Copy link
Member

Feature Description

Search bar on homepage doesn't work with collapsible menus
If the menu is collapsed and you do a search it doesn't detect the elements since they are removed from UI

Additionally when searching
image
it shows all the other menus but empty which adds nothing to the UI and only clutter
Suggestion is to remove all empty fields when this happens

Why is this feature valuable?

Clean and understandable UI

Suggested Implementation

No response

Additional Information

No response

No Duplicate of the Feature

  • I have verified that there are no existing features requests similar to my request.
@Frooodle Frooodle added enhancement New feature or request Bug Something isn't working good first issue Good for newcomers Front End Issues or pull requests related to front-end development labels Nov 18, 2024
@Frooodle Frooodle moved this to Todo in Stirling-PDF V1 Nov 18, 2024
@Frooodle Frooodle changed the title [Feature Request]: Search bar on homepage doesn't work with collapsible menus [Bug]: Search bar on homepage doesn't work with collapsible menus Nov 18, 2024
@omar-ahmed42
Copy link
Contributor

Can I contribute in solving this bug?

Also, can you clarify "If the menu is collapsed and you do a search it doesn't detect the elements since they are removed from UI"? As I tried searching with collapsed menus and it correctly displayed the feature groups that has the cards matching the search criteria and when expanded it actually displayed the cards matching the criteria (as demonstrated in the attached GIF).

cluttered-search-ui

As for hiding/removing empty menus (accordions/feature-groups) to clean the UI from clutter (as mentioned in the second part of the issue), I have an idea of what's causing the issue and might start upon having the issue assigned to me.

@Frooodle
Copy link
Member Author

A user performing a search shouldn't need to manually expand each element to check if their searches entry is inside it
The search should auto expand them

@omar-ahmed42
Copy link
Contributor

Thank you for the clarification

@omar-ahmed42 omar-ahmed42 mentioned this issue Nov 20, 2024
Merged
7 tasks
Frooodle added a commit that referenced this issue Nov 21, 2024
@omar-ahmed42 @Frooodle
Fix: Expand and de-clutter menus for matching search results in homep…
aeca2b2 
…age #2264 (#2277)

* Hide empty menus that don't match search criteria

- Hide empty menus (accordions/feature groups) that don't match search criteria.

* Expand menus automatically for matching search results

- Fix a bug where menus (accordions/feature groups) did not automatically expand on the homepage when search results matched.

---------

Co-authored-by: Anthony Stirling <77850077+Frooodle@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Next to pickup to Done in Stirling-PDF V1 Nov 21, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@omar-ahmed42 omar-ahmed42

Labels
Bug Something isn't working enhancement New feature or request Front End Issues or pull requests related to front-end development good first issue Good for newcomers
Projects
Stirling-PDF V1
Status: Done
Milestone
No milestone
2 participants
@Frooodle @omar-ahmed42