Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closes #359 #1047

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Closes #359 #1047

merged 1 commit into from
Apr 8, 2024

Conversation

DimK10
Copy link
Collaborator

@DimK10 DimK10 commented Apr 8, 2024

Description

Fixes the bug of not transferring the pdf metadata to the newly created split pdf files.

Closes #(issue_number)

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

@DimK10 DimK10 requested a review from Frooodle as a code owner April 8, 2024 19:55
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Frooodle Frooodle merged commit 471865e into Stirling-Tools:main Apr 8, 2024
4 checks passed
@DimK10 DimK10 deleted the 359-split-metadata-lost branch April 8, 2024 20:30
@Frooodle
Copy link
Member

Frooodle commented Apr 8, 2024

Realise this should probably modify the modified date not keep it same?
@DimK10

@DimK10
Copy link
Collaborator Author

DimK10 commented Apr 8, 2024

Oops! You are right, let me fix that!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants