-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Text color selection for watermark #2415
Merged
Frooodle
merged 3 commits into
Stirling-Tools:main
from
saikumarjetti:TextColor-selection-for-Watermark
Dec 7, 2024
Merged
Text color selection for watermark #2415
Frooodle
merged 3 commits into
Stirling-Tools:main
from
saikumarjetti:TextColor-selection-for-Watermark
Dec 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
enhancement
New feature or request
labels
Dec 7, 2024
github-actions
bot
added
Java
Pull requests that update Java code
Front End
Issues or pull requests related to front-end development
Back End
Issues related to back-end development
Translation
API
API-related issues or pull requests
labels
Dec 7, 2024
🚀 Translation Verification Summary🔄 Reference Branch:
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
API
API-related issues or pull requests
Back End
Issues related to back-end development
enhancement
New feature or request
Front End
Issues or pull requests related to front-end development
Java
Pull requests that update Java code
size:M
This PR changes 30-99 lines, ignoring generated files.
Translation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses Feature Request #369 by adding the ability for users to select a custom text color for watermarks in PDF documents.
Key Changes
WatermarkController.java
AddWatermarkRequest.java
Introduced customColor field with a default value of #d3d3d3.
Localization
Added watermark.customColor key to all existing Localization files with values matching addWatermarkRequest.customColor to ensure consistency across languages.
add-watermark.html
Closes #369
Checklist