Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix draggableElement is null by removing draggable.js #2485

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Fix draggableElement is null by removing draggable.js #2485

merged 2 commits into from
Dec 17, 2024

Conversation

omar-ahmed42
Copy link
Contributor

Description

  • Remove draggable.js as the draggability feature already works without it and it wasn't used anywhere except in sign.html (which threw an exception already, as draggableElement was null, and yet the functionality was working as expected, thus we don't need it).

Closes #2478

Checklist

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have attached images of the change if it is UI based
  • I have commented my code, particularly in hard-to-understand areas
  • If my code has heavily changed functionality I have updated relevant docs on Stirling-PDFs doc repo
  • My changes generate no new warnings
  • I have read the section Add New Translation Tags (for new translation tags only)

@omar-ahmed42
Remove unused draggable.js file
5d4769d 
- Remove draggable.js as the draggability feature already works without and it wasn't used anywhere except in sign.html (which throw an exception already as draggableElement was null, and yet the functionality was working as expected, thus we don't need it)
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Bug Something isn't working labels Dec 17, 2024
@github-actions github-actions bot added Front End Issues or pull requests related to front-end development and removed Bug Something isn't working labels Dec 17, 2024
@Frooodle
Copy link
Member

Really impressed with all this work and PRs! thanks again
Are you part of our discord? Would love to chat :D

@Frooodle Frooodle enabled auto-merge December 17, 2024 11:15
@Frooodle Frooodle merged commit 8053035 into Stirling-Tools:main Dec 17, 2024
6 checks passed
@omar-ahmed42
Copy link
Contributor Author

omar-ahmed42 commented Dec 17, 2024 •
edited
Loading

Are you part of our discord?

I just joined now

Would love to chat :D

Sure :D

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Frooodle Frooodle Frooodle approved these changes

Assignees
No one assigned
Labels
Front End Issues or pull requests related to front-end development size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: draggableElement is null
2 participants
@omar-ahmed42 @Frooodle