Switch inner-text parsing to textContent from innerText #5514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkrives
approved these changes
Oct 30, 2021
|
We should write tests too |
|
I'm happy to write tests. I'm also starting to think this should be moved to the proxy server instead of it happening client-side. |
rye
approved these changes
Oct 30, 2021
There was a problem hiding this comment.
I definitely agree with @hawkrives that this seems like a good candidate for testing.
|
Let's merge this and file an issue to write tests? I'm also happy to move it to the server, assuming everything we use it on goes through there. (But it still needs tests at that point😁) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
innerTextwas creating and returning an object whereastextContentreturns a string