Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor news components #6060

Merged
merged 7 commits into from
May 16, 2022
Merged

Refactor news components #6060

merged 7 commits into from
May 16, 2022

Conversation

drewvolz
Copy link
Member

@drewvolz drewvolz commented May 13, 2022 •
edited
Loading

Recommend viewing without whitespace

  • deduplicate our components by combining news list and container
  • rewrite list and row as functional components
  • useFetch/useAsync hooks for data state
  • add new tab navigator to news index

@drewvolz drewvolz requested review from hawkrives and rye as code owners May 13, 2022 07:39
Base automatically changed from drew/dictionary-hook to master May 16, 2022 04:57
@drewvolz drewvolz enabled auto-merge May 16, 2022 05:23
@drewvolz drewvolz merged commit 5fc1777 into master May 16, 2022
@drewvolz drewvolz deleted the drew/news branch May 16, 2022 05:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hawkrives hawkrives hawkrives approved these changes

@rye rye rye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drewvolz @hawkrives @rye