Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

adding a fix for urls on loaded pages to be protocol based in getNext… #117

Closed
wants to merge 1 commit into from
Closed

adding a fix for urls on loaded pages to be protocol based in getNext… #117

wants to merge 1 commit into from

Conversation

janmyszkier
Copy link

…Url function

@janmyszkier janmyszkier mentioned this pull request Aug 28, 2015
Closed
@damian-pastorini
Copy link
Contributor

@janmyszkier , can we move the fix outside of the library file?

Like:

  • Extend the library object
  • Apply the fix in our custom "new" object
  • And make the IS use that object instead of the original one

@damian-pastorini
Copy link
Contributor

Since this is an issue in the IAS library I overrided the getNextUrl method after load the library.
Closing this PR, you can check the fix in here: #131

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@damian-pastorini damian-pastorini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janmyszkier @damian-pastorini