Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CI: Test against rails 7.0 #43

Merged
merged 6 commits into from
Jul 6, 2023

Conversation

meganemura
Copy link

@meganemura meganemura commented May 1, 2023

Why?

This PR aims to update the CI configuration to support testing for Rails 7.0, which is an important update for the project. Ensuring compatibility with Rails 7.0 will make the project more robust and up-to-date, as well as maintain support for the latest features and improvements.

What?

The changes made in this PR involve updating the CI configuration to run tests targeting Rails 7.0. This will help ensure that the project remains compatible with the latest version of Rails and that any potential issues or conflicts are detected and addressed promptly.

Caveats

In this pull request, the CI configuration has been updated to run tests for Rails 7.0. However, it is unverified whether this is sufficient for full compatibility with Rails 7.0.

Testing Notes

  • Test that the CI pipeline runs successfully with Rails 7.0
  • Test that all existing tests pass with Rails 7.0

Alternatives Considered

N/A

Further Reading

Merge Instructions

Please DO NOT squash my commits when merging.

@meganemura meganemura changed the title WIP WIP: Support rails 7.0 May 1, 2023
@meganemura meganemura changed the title WIP: Support rails 7.0 CI: Test against rails 7.0 May 1, 2023
@meganemura meganemura marked this pull request as ready for review May 1, 2023 23:54
@meganemura meganemura marked this pull request as draft May 1, 2023 23:55
@meganemura meganemura marked this pull request as ready for review May 1, 2023 23:56
@meganemura
Copy link
Author

@katsuyasu-murata @valerauko

When you have a moment, could you please take a look at this PR?

@valerauko
Copy link

We're tweaking the CI now so that tests can run from forked PRs

@valerauko valerauko merged commit 2e3ad75 into StudistCorporation:master Jul 6, 2023
@valerauko
Copy link

@meganemura thanks for your contribution!

@meganemura meganemura deleted the rails-70 branch July 6, 2023 05:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants